[
https://issues.apache.org/jira/browse/HDDS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710786#comment-16710786
]
Allen Wittenauer commented on HDDS-891:
---------------------------------------
bq. Please note that the hadoop-ozone and hadoop-hdds in the current trunk
doesn't depend on the in-tree hadoop-hdfs/common projects. It depends on the
hadoop-3.2-SNAPSHOT as of now and we would like to switch to a stable release
as soon as possible.
That won't always be the case unless Ozone becomes its own project. There's no
value in creating technical debt here.
bq. Technically it's possible
Yup: HDDS-146, for example, changed start-build-env.sh (and introduced a bug).
So clearly there is still some dependence despite everything said above.
bq. b): I like the idea and I tried to implement it. Would you be so kind to
review the v2 patch of YETUS-631?
YETUS-631 isn't an implementation of b at all. [and, FWIW, I'm going to reject
that patch. I've got a better fix as part of YETUS-723.]
bq. I checked the last two commits: If I understood well there was an
additional property in the root pom.xml for ozone version (low risk) and with
the last commit it was removed, so the parent pom.xml shouldn't be modified any
more.
Irrelevant. A change is a change. There is no way to guarantee that further
changes won't leak outside these two modules short of not having any other code
in the branch/repo.
My binding vote remains -1.
> Create customized yetus personality for ozone
> ---------------------------------------------
>
> Key: HDDS-891
> URL: https://issues.apache.org/jira/browse/HDDS-891
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
>
> Ozone pre commit builds (such as
> https://builds.apache.org/job/PreCommit-HDDS-Build/) use the official hadoop
> personality from the yetus personality.
> Yetus personalities are bash scripts which contain personalization for
> specific builds.
> The hadoop personality tries to identify which project should be built and
> use partial build to build only the required subprojects because the full
> build is very time consuming.
> But in Ozone:
> 1.) The build + unit tests are very fast
> 2.) We don't need all the checks (for example the hadoop specific shading
> test)
> 3.) We prefer to do a full build and full unit test for hadoop-ozone and
> hadoop-hdds subrojects (for example the hadoop-ozone integration test always
> should be executed as it contains many generic unit test)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
