[
https://issues.apache.org/jira/browse/HDDS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712998#comment-16712998
]
Elek, Marton commented on HDDS-879:
-----------------------------------
Thanks [~bharatviswa] the patch. Overall it looks very good to me. Thanks for
the long comment in the KeyManagerImpl (very useful) and the additional audit
events.
One note: Until now we had a convention to use Om*Args as the parameter of the
OzoneManagerProtocolClientSideTranslatorPB client and Om*Info as the response
from this client. The RpcClient itself used simple types as the parameters and
client specific objects (Such asn OzoneVolume and OzoneBucket).
With this patch it will be changed. The OmKeyInfo itself is used on the rpc
client side as a response. I understand why: it's so simple that we need
exactly the same object type, but it maybe useful to follow this convention
even if it's not the better.
But not a strict requirement. This is just something which can be considered.
And a nit: The finally block is not strictly required in OzoneManager (If I
understood well). we can use the AUDIT.logWriteSuccess as the last step inside
the try bock. (But again, not very important. The current implementation also
works good just with a few additional lines).
But with these comments I am +1 for the patch.
> MultipartUpload: Add InitiateMultipartUpload in ozone
> -----------------------------------------------------
>
> Key: HDDS-879
> URL: https://issues.apache.org/jira/browse/HDDS-879
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Attachments: HDDS-879.01.patch, HDDS-879.02.patch, HDDS-879.03.patch,
> HDDS-879.04.patch, HDDS-879.05.patch
>
>
> This Jira is to add initiate multipart upload.
> InitiateMultipart upload does 2 things:
> # Create an entry in the open table for this key
> # Add multipartInfo information for this key in to multipartinfo table.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
