[
https://issues.apache.org/jira/browse/HDDS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713152#comment-16713152
]
Bharat Viswanadham commented on HDDS-879:
-----------------------------------------
Hi [~elek]
Thanks for the review.
{quote}With this patch it will be changed. The OmKeyInfo itself is used on the
rpc client side as a response. I understand why: it's so simple that we need
exactly the same object type, but it maybe useful to follow this convention
even if it's not the better.
{quote}
I feel previously this is done, as from Om*Info response we set it into
OzoneVolume and OzoneBucket, and these have an additional thing called proxy in
them, which is useful in further invoke operations on them, that might be the
reason for doing this way. But here as we need a same response, we can use I
believe. And we don't bring any additional dependencies by using a class from
another module, as this class is any way in hadoop-ozone/common and
hadoop-ozone/client is already dependent on. Let me know if you still want to
have a new class for this response.
{quote}And a nit: The finally block is not strictly required in OzoneManager
(If I understood well). we can use the AUDIT.logWriteSuccess as the last step
inside the try bock. (But again, not very important. The current implementation
also works good just with a few additional lines).
{quote}
Done.
> MultipartUpload: Add InitiateMultipartUpload in ozone
> -----------------------------------------------------
>
> Key: HDDS-879
> URL: https://issues.apache.org/jira/browse/HDDS-879
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Attachments: HDDS-879.01.patch, HDDS-879.02.patch, HDDS-879.03.patch,
> HDDS-879.04.patch, HDDS-879.05.patch, HDDS-879.06.patch
>
>
> This Jira is to add initiate multipart upload.
> InitiateMultipart upload does 2 things:
> # Create an entry in the open table for this key
> # Add multipartInfo information for this key in to multipartinfo table.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
