[
https://issues.apache.org/jira/browse/HDDS-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713220#comment-16713220
]
Anu Engineer commented on HDDS-909:
-----------------------------------
Thanks for the patch. I think there is an issue, please verify if what I am
saying is true.
we do this operation to break a string to paths
{code:java}
pathComponents = (List<String>) StringUtils.getStringCollection(getPath(),
OzoneConsts.OZONE_URI_DELIMITER);
{code}
Later we do
{code:java}
@Override
public String getKeyName() {
if (pathComponents.size() > 2) {
return pathComponents.get(2);
} else {
return null;
}
}
{code}
I am worried that this will fail if the key itself has OZONE URI DELIMITER.
That is a legal key name.
Since I was looking at this I also realized we don't have tests for the
getKeyName call, It would be nice to add some tests for getKeyName, and
specifically for this case. There are probably some check style issues too, but
we can wait for Jenkins to flag them.
> Default implementation for Ozone acls
> -------------------------------------
>
> Key: HDDS-909
> URL: https://issues.apache.org/jira/browse/HDDS-909
> Project: Hadoop Distributed Data Store
> Issue Type: New Feature
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDDS-909.00.patch
>
>
> Default implementation for Ozone acls
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
