[
https://issues.apache.org/jira/browse/HDDS-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713401#comment-16713401
]
Anu Engineer commented on HDDS-909:
-----------------------------------
Thanks for updating the patch. Some minor comments inline.
# {code}
default:
return OzoneConsts.OZONE_URI_DELIMITER;
{code}
Not sure I understand why we are returning OZONE_URI_DELIMITER in the default
case.
# In TestOzoneObjInfo
{code}
.setResType(RESOURCE_TYPE)
{code}
SetResourceType(resource) is not very easy to understand, did you intended to
write the setResType(Volume_Type)
# in TestOzoneObjInfo#testGetBucketName - line 69, 70 looks same as 72,73. Just
want to make sure it is intentional.
+1, once these are addressed and there might be some checkStyle issues that you
might need to take care from the jenkins.
> Default implementation for Ozone acls
> -------------------------------------
>
> Key: HDDS-909
> URL: https://issues.apache.org/jira/browse/HDDS-909
> Project: Hadoop Distributed Data Store
> Issue Type: New Feature
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDDS-909.00.patch, HDDS-909.01.patch
>
>
> Default implementation for Ozone acls
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
