[
https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719577#comment-16719577
]
Chao Sun commented on HDFS-14146:
---------------------------------
Thanks [~vagarychen] and [~xkrogen] for the quick response.
{quote}in what situation did you get issue?
{quote}
I haven't seen this issue happen yet - just noticed it when examine the code.
{quote}Normally, reader threads attempt to offer a request to the callQueue ...
{quote}
Good point! I couldn't come up with an example (It would be great if you have
one) that causing all the handlers to stuck yet, but certainly can see that
some handlers get blocked when putting the call back, which is undesirable.
Changing {{put}} to {{add}} makes sense to me.
{quote}It's not clear to me if the logic you added will match this; can you
confirm?
{quote}
Yes I compared this code with {{Call#doResponse}} - they are doing the same
thing.
> Handle exception from internalQueueCall
> ---------------------------------------
>
> Key: HDFS-14146
> URL: https://issues.apache.org/jira/browse/HDFS-14146
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ipc
> Reporter: Chao Sun
> Assignee: Chao Sun
> Priority: Critical
> Attachments: HDFS-14146-HDFS-12943.000.patch
>
>
> When we re-queue RPC call, the {{internalQueueCall}} will potentially throw
> exceptions (e.g., RPC backoff), which is then swallowed. This will cause the
> RPC to be silently discarded without response to the client, which is not
> good.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
