[
https://issues.apache.org/jira/browse/HDFS-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720468#comment-16720468
]
Erik Krogen commented on HDFS-14146:
------------------------------------
Nice job [~csun], this looks great! I have a few very minor style nits:
* The comment about blocking within {{internalQueueCall()}} is on the wrong
method ({{add()}} instead of {{put()}})
* For {{Server#requeueCall()}}, the {{throws}} should be on the same line as
the exceptions?
* You're missing a space before the curly brace on Server L2758
The test is clever!
> Handle exception from internalQueueCall
> ---------------------------------------
>
> Key: HDFS-14146
> URL: https://issues.apache.org/jira/browse/HDFS-14146
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ipc
> Reporter: Chao Sun
> Assignee: Chao Sun
> Priority: Critical
> Attachments: HDFS-14146-HDFS-12943.000.patch,
> HDFS-14146-HDFS-12943.001.patch
>
>
> When we re-queue RPC call, the {{internalQueueCall}} will potentially throw
> exceptions (e.g., RPC backoff), which is then swallowed. This will cause the
> RPC to be silently discarded without response to the client, which is not
> good.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
