[
https://issues.apache.org/jira/browse/HDDS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723715#comment-16723715
]
Xiaoyu Yao commented on HDDS-805:
---------------------------------
Thanks [~ajayydv] for the update. Patch v6 looks good to me. A few more
comments:
ContainerProtocolCalls.java
Line 112: datanodeBlockID is the protobuf format and the toString() may not
match with the blockID#toString() in other paces when calling
getEncodedBlockToken().
Line 392/424/454/482: please update the javadoc after adding the parameter
Line 564: please add document wrt. the format of the service that are expected
passing in here.
Line 567: should we have a static OzoneBlockTokenSelector to avoid create
object upon each call?
KeyManagerImpl.java
Line 216: If the server does not provider remote user info, are we suppose to
throw here?
I don't think we should use OM's current user as remote user for block token.
OzoneManager.java
Line 335: NIT: use Objects.notNull to replace Preconditions.checkNotNull?
Line 368: switch the order of the if condition to check isGrpcBlockTokenEnabled
first?
Line 373/385: NIT: Inability->Unable
Line 375: the error message can be refined to "block token secret manager"
Line 387: "delegation token secret manager"
ChunkOutputStreamEntry.java
Line 70/78: redundant token initializations.
TestSecureOzoneRpcClient.java
Line 135-139: can be wrapped with try-with-resource (same with line 174-180)
Line 142-150: input steam needs to be closed, ideally with try-with-resource
> Block token: Client api changes for block token
> -----------------------------------------------
>
> Key: HDDS-805
> URL: https://issues.apache.org/jira/browse/HDDS-805
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Security
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDDS-805-HDDS-4.00.patch, HDDS-805-HDDS-4.01.patch,
> HDDS-805-HDDS-4.02.patch, HDDS-805-HDDS-4.03.patch, HDDS-805-HDDS-4.04.patch,
> HDDS-805-HDDS-4.05.patch, HDDS-805-HDDS-4.06.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
