[
https://issues.apache.org/jira/browse/HDDS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719314#comment-16719314
]
Ajay Kumar commented on HDDS-805:
---------------------------------
[~xyao] thanks for review.
{quote}ChunkgroupInputStream.java
Line 302: what's the block token service field here?{quote}
It is block id.
{quote}If we are using the same token service field, only one token might be
added to UGI.{quote}
ya, if all omKeyLocationInfo aree for same block than it will add only one
token and i think that is what we expect.
{quote}Found it in OzoneBLockTokenSecretmanager#generateToken(), seems we are
using blockID as the token service field. Can we add more comments on this.
{quote}
Done.
{quote} Do we need a different token selector to select the appropriate token
when using the UGI with multiple block tokens?{quote}
You are right, added check for service field in {{OzoneBlockTokenSelector}}
{quote}ContainerOperationClient.java
Line 118: please add TODO or followup JIRAs to add DN tokens for these
operations.{quote}
Done. Follow up jira: [HDDS-923]
{quote}KeyManagerImpl.java
Line 216: do we assume HadoopRPC always have remote user setup already here?If
not, I don't think we should use the OM current user context as remote user.
{quote}
Hadoop rpc coming should have an remote caller. This code is taken from
Namenode. If remote user ugi is null shall we do something else?
XCeiverClientManager.java
Line 152/160: if we move the client.connect() for RATIS only, do we miss a
connect for STAND_ALONE?
No, this is intentional. For grpc we will connect when we will send the actual
command.
> Block token: Client api changes for block token
> -----------------------------------------------
>
> Key: HDDS-805
> URL: https://issues.apache.org/jira/browse/HDDS-805
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Security
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDDS-805-HDDS-4.00.patch, HDDS-805-HDDS-4.01.patch,
> HDDS-805-HDDS-4.02.patch, HDDS-805-HDDS-4.03.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
