[ 
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739034#comment-16739034
 ] 

Bharat Viswanadham commented on HDDS-960:
-----------------------------------------

Hi,
Thank You [~dineshchitlangia] for the contribution.
Over all patch LGTM.
Few comments:
1. Can we rename S3SecretCommands.java -> S3Commands.java. As we want to add 
ozone sh bucket path under this. 
2. In S3 commands we are setting OM address, do we need it for ozone cli on 
cluster too?


> Add cli command option for getS3Secret
> --------------------------------------
>
>                 Key: HDDS-960
>                 URL: https://issues.apache.org/jira/browse/HDDS-960
>             Project: Hadoop Distributed Data Store
>          Issue Type: New Feature
>          Components: Ozone CLI, S3
>            Reporter: Dinesh Chitlangia
>            Assignee: Dinesh Chitlangia
>            Priority: Major
>         Attachments: HDDS-960-HDDS-4.01.patch, HDDS-960.01.patch, 
> HDDS-960.02.patch
>
>
> HDDS-937 and HDDS-938 introduced Client/Server APIs to generate/fetch S3 
> secret.
> This jira aims to provide a CLI command to use the above feature.
> Proposed usage:
> ozone sh s3 getkey



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to