[ 
https://issues.apache.org/jira/browse/HDDS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739807#comment-16739807
 ] 

Ajay Kumar commented on HDDS-960:
---------------------------------

[~dineshchitlangia] thanks for the updated patch. LGTM. 
TestOzoneShell:
* L1179 : I think getting service address (host with port) is useful in other 
places as well. Shall we add a {{String getServiceAddress(ServicePort port)}} 
api in {{ServiceInfo}} class to handle this other similar cases?
{code}String omHostName = services.stream().filter(
        a -> a.getNodeType().equals(HddsProtos.NodeType.OM))
        .collect(Collectors.toList()).get(0).getHostname();{code}

* assert that outputFirstAttempt contains secret?




> Add cli command option for getS3Secret
> --------------------------------------
>
>                 Key: HDDS-960
>                 URL: https://issues.apache.org/jira/browse/HDDS-960
>             Project: Hadoop Distributed Data Store
>          Issue Type: New Feature
>          Components: Ozone CLI, S3
>            Reporter: Dinesh Chitlangia
>            Assignee: Dinesh Chitlangia
>            Priority: Major
>         Attachments: HDDS-960-HDDS-4.01.patch, HDDS-960-HDDS-4.02.patch, 
> HDDS-960.01.patch, HDDS-960.02.patch, Screen Shot 2019-01-10 at 1.16.00 AM.png
>
>
> HDDS-937 and HDDS-938 introduced Client/Server APIs to generate/fetch S3 
> secret.
> This jira aims to provide a CLI command to use the above feature.
> Proposed usage:
> ozone sh s3 getkey



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to