[ 
https://issues.apache.org/jira/browse/HDDS-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750101#comment-16750101
 ] 

Arpit Agarwal commented on HDDS-989:
------------------------------------

Thank you for the review [~linyiqun].

bq. Can we rename the name numSyncChecks to numAllVolumesChecks
Fixed.

bq. why not be CountDownLatch(volumes.size())?
The latch is triggered when all volumes have completed checking, so 1 is 
correct here.

bq. Can we print a error log with the exception here?
Fixed.

> Check Hdds Volumes for errors
> -----------------------------
>
>                 Key: HDDS-989
>                 URL: https://issues.apache.org/jira/browse/HDDS-989
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: Ozone Datanode
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>            Priority: Major
>         Attachments: HDDS-989.01.patch, HDDS-989.02.patch, HDDS-989.03.patch
>
>
> HDDS volumes should be checked for errors periodically.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to