[ 
https://issues.apache.org/jira/browse/HDDS-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761696#comment-16761696
 ] 

Shashikant Banerjee commented on HDDS-972:
------------------------------------------

Thanks [~hanishakoneru] for updating the patch. The patch looks good to me. 
Some minor comments:

1. TestOzoneManagerConfiguration : 190 -> Comments need to be updated correctly

2.Ozone-Default.xml : "Comma-separated list of OM node Ids for a given OM 
service for a givenOM service ID " ->  Comma-separated list of OM node Ids for 
a given OM service ID"

3.OmUtils#isReadOnly should throw an exception in case of a invalid command 
instead of logging as error.

4. If OmServiceId and OMNodeId values are not , we set it to 
OzoneConsts.OM_SERVICE_ID_DEFAULT and omId set in the version file in OM. 
Should we add this info in Ozone-default.xml as well?

5. OzoneManagerRatisClient will be a single instance running in OM . We may not 
need to maintain reference count on RaftClient instance. We can just have a 
single raft client instance running in OzoneManagerRatisClient.

> Add support for configuring multiple OMs
> ----------------------------------------
>
>                 Key: HDDS-972
>                 URL: https://issues.apache.org/jira/browse/HDDS-972
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>            Priority: Major
>         Attachments: HDDS-972.000.patch, HDDS-972.001.patch, 
> HDDS-972.002.patch
>
>
> For OM HA, we would need to run multiple (atleast 3) OM services so that we 
> can form a replicated Ratis ring of OMs. This Jira aims to add support for 
> configuring multiple OMs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to