[
https://issues.apache.org/jira/browse/HDFS-14258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763067#comment-16763067
]
BELUGA BEHR edited comment on HDFS-14258 at 2/7/19 9:09 PM:
------------------------------------------------------------
New patch (and updated git PR)
Since I'm touching a large part of the file, I've gone back and fixed up a
bunch of check-style errors and added a bunch of comments.
If the class is not unable to lower the thread count within 30s, it fails and
returns a boolean to the calling code so that a proper Exception can be thrown.
I am very hesitant to add a new configuration here. Hadoop already has 1,000+
undocumented/under-documented valves to turn. The fix here is that if it
doesn't work the first time, try re-configuring the DataNode again.
Also note that the default number of threads currently is 50. It will be more
likely to succeed going to 48 (-2) threads than going to 10 (-40) threads on a
busy cluster. I'm not sure why one would want to do that, but if required,
they could always re-configure the DN in a few smaller iterations instead of
one big one.
was (Author: belugabehr):
New patch (and updated git PR)
Since I'm touching a large part of the file, I've gone back and fixed up a
bunch of check-style errors and added a bunch of comments.
If the class is not unable to lower the thread count within 30s, it fails and
returns a boolean to the calling code so that a proper Exception can be thrown.
I am very hesitant to add a new configuration here. Hadoop already has 1,000+
undocumented/under-documented valves to turn. The fix here is that if it
doesn't work the first time, try re-configuring the DataNode again.
> Introduce Java Concurrent Package To DataXceiverServer Class
> ------------------------------------------------------------
>
> Key: HDFS-14258
> URL: https://issues.apache.org/jira/browse/HDFS-14258
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.2.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HDFS-14258.1.patch, HDFS-14258.2.patch,
> HDFS-14258.3.patch, HDFS-14258.4.patch
>
>
> * Use Java concurrent package to replace current facilities in
> {{DataXceiverServer}}.
> * A little bit of extra clean up
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
