[ 
https://issues.apache.org/jira/browse/HDDS-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763142#comment-16763142
 ] 

Xiaoyu Yao commented on HDDS-1012:
----------------------------------

Thanks [~ajayydv] for the update.

 

Here are a few minor comments:

CertificateClient.java

Line 138/148: should be IOException

Line 154/172/: remove the component

 

SecurityConfig.java

Line 414: Can you clarify if we expect OM/DN to use the getTrustStoreFile() on 
line 404 or Line 414? 

 

DefaultCAClient.java

Line 214: should we change OM to use certificate to verify signature based on 
certificate.

Line 199/232: rename the exception code to fail to verify signature

Line 273: remove from the interface as we don't need it anymore

Line 453: the init() will be different for OM and DN. Should we move this out 
for DN implementation only?

 

 

 

> Add Default CertificateClient implementation
> --------------------------------------------
>
>                 Key: HDDS-1012
>                 URL: https://issues.apache.org/jira/browse/HDDS-1012
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>            Priority: Major
>              Labels: Blocker
>         Attachments: HDDS-1012.01.patch, HDDS-1012.02.patch, 
> HDDS-1012.03.patch, HDDS-1012.04.patch
>
>
> Add Default CertificateClient implementation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to