[
https://issues.apache.org/jira/browse/HDDS-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763851#comment-16763851
]
Xiaoyu Yao commented on HDDS-1012:
----------------------------------
Thanks [~ajayydv] for the update. Patch v7 looks good to me. A few more minor
comments:
Checkstyle needs to be fixed. (Somehow the one from hadoop-build-tools/src is
different from the on run by Jenkins
TestDefaultCertificateClient failure needs to be investigated.
CertificateClient.java
Line 134: doc update
Line 152-165: Let's keep the init() abstract and leave the details for DN and
OM in their implementation.
Instead of having all in the DefaultCAClient, can we have the implementation
like below hierarchy, where the init() are override in
DatanodeCertificateClient
and OMCertificateClient, respectively.
CertificateClient->DefaultCertificateClient->DatanodeCertificateClient
CertificateClient->DefaultCertificateClient->OMCertificateClient
DefaultCertificateClient.java
Line 306: the exception message can be improved like "Error while verifying
signature", Also, we should use
CRYPTO_SIGNATURE_VERIFICATION_ERROR instead of CRYPTO_SIGN_ERROR
Line 624: should we check if (initCase & 1<<2) ==1 instead to indicate if key
exist as true? same apply other conditions in the default case.
Line 660: should we finish writing before change the in-memory state of
publicKey?
Line 689: NIT: suggest renaming to bootstrapClientKeys or bootstrapKeypair to
match the scope of the function.
> Add Default CertificateClient implementation
> --------------------------------------------
>
> Key: HDDS-1012
> URL: https://issues.apache.org/jira/browse/HDDS-1012
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Labels: Blocker
> Attachments: HDDS-1012.01.patch, HDDS-1012.02.patch,
> HDDS-1012.03.patch, HDDS-1012.04.patch, HDDS-1012.05.patch,
> HDDS-1012.06.patch, HDDS-1012.07.patch
>
>
> Add Default CertificateClient implementation
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
