[
https://issues.apache.org/jira/browse/HDDS-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764861#comment-16764861
]
Lokesh Jain commented on HDDS-360:
----------------------------------
[~anu] Thanks for working on this! The patch looks very good to me. Please find
my comments below.
# DeletedBlockLogImpl:80 - We can remove the throws clause.
# DeletedBlockLogImpl#getFailedTransactions - We need to iterate through the
entries in the table. Currently we are just checking the first entry in the
table.
# DeletedBlockLogImpl#getNumOfValidTransactions - same as point 2.
# DeletedBlockLogImpl#addTransactions - We can make it as a batch operation.
# SCMMetadataStore#getNextTXID can be renamed to getNextDeleteBlockTxnID?
> Use RocksDBStore and TableStore for SCM Metadata
> ------------------------------------------------
>
> Key: HDDS-360
> URL: https://issues.apache.org/jira/browse/HDDS-360
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Xiaoyu Yao
> Assignee: Anu Engineer
> Priority: Major
> Attachments: HDDS-360.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
