[
https://issues.apache.org/jira/browse/HDDS-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765376#comment-16765376
]
Anu Engineer commented on HDDS-360:
-----------------------------------
[~ljain] Thanks for the comments. I have fixed the test failure and have
addressed all review comments. Please see below for details.
bq. DeletedBlockLogImpl:80 - We can remove the throws clause.
Fixed.
bq. DeletedBlockLogImpl#getFailedTransactions - We need to iterate through the
entries in the table. Currently, we are just checking the first entry in the
table.
Very good catch, thanks. Fixed.
bq. DeletedBlockLogImpl#getNumOfValidTransactions - same as point 2.
Thanks, fixed.
bq. DeletedBlockLogImpl#addTransactions - We can make it as a batch operation.
Thanks, fixed.
bq. SCMMetadataStore#getNextTXID can be renamed to getNextDeleteBlockTxnID?
Fixed.
> Use RocksDBStore and TableStore for SCM Metadata
> ------------------------------------------------
>
> Key: HDDS-360
> URL: https://issues.apache.org/jira/browse/HDDS-360
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Xiaoyu Yao
> Assignee: Anu Engineer
> Priority: Major
> Attachments: HDDS-360.001.patch, HDDS-360.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
