[
https://issues.apache.org/jira/browse/HDFS-14262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765277#comment-16765277
]
Wei-Chiu Chuang commented on HDFS-14262:
----------------------------------------
To elaborate, here's the code in discussion
{code:title=GlobalStateIdContext#receiveRequestState}
if (clientStateId > serverStateId &&
HAServiceState.ACTIVE.equals(namesystem.getState())) {
FSNamesystem.LOG.warn("A client sent stateId: " + clientStateId +
", but server state is: " + serverStateId);
return serverStateId;
}
{code}
If this condition is ever satisfied, an admin wouldn't understand why this is
logged. Instead, it should log "A client sent stateId: " + clientStateId + " is
larger than server state: " + serverStateId + ". This is unexpected. I will
reset client stateId to server stateId"
FYI [~xkrogen]
> Unclear Log.WARN message in GlobalStateIdContext
> ------------------------------------------------
>
> Key: HDFS-14262
> URL: https://issues.apache.org/jira/browse/HDFS-14262
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Shweta
> Assignee: Shweta
> Priority: Major
>
> The check clientStateId > serverStateId during active HA status might never
> occur and the log message is pretty unclear, should it throw an Exception
> instead?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
