[
https://issues.apache.org/jira/browse/HDFS-14226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766312#comment-16766312
]
Íñigo Goiri commented on HDFS-14226:
------------------------------------
Thanks [~ayushtkn] for [^HDFS-14226-HDFS-13891-03.patch].
There is a bunch of javac, checkstyle and other minor issues reported by Yetus
we should handle.
Some comments:
* Can we extend the comment in {{isInvokeConcurrent()}} explaining the purpose.
Basically summarizing the findings in this JIRA.
* Extract {{(MountTableResolver) subclusterResolver}} in
{{isInvokeConcurrent()}}.
* Rename {{setUpTestEnviornment()}} to {{setupOrderMountPath()}}.
* I think setting up a full cluster for every test is pretty expensive. We
should create one in BeforeClass and then do some cleanup at the end of the
tests to make sure all the /tmp files and mount entries aren't there for the
next test.
* When we call {{testInvocation()}} with false or true, we may want to do it
through code checking the MountTable methods.
* Instead of reusing {{checked}} all the time, we might want to create a new
one for each with a name with some description.
* Unify the format of the comments with the spaces throughout
{{testInvocation()}}.
Can others help take a look?
> RBF: Setting attributes should set on all subclusters' directories.
> -------------------------------------------------------------------
>
> Key: HDFS-14226
> URL: https://issues.apache.org/jira/browse/HDFS-14226
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Takanobu Asanuma
> Priority: Major
> Labels: RBF
> Attachments: HDFS-14226-HDFS-13891-01.patch,
> HDFS-14226-HDFS-13891-02.patch, HDFS-14226-HDFS-13891-03.patch,
> HDFS-14226-HDFS-13891-WIP1.patch
>
>
> Only one subcluster is set now.
> {noformat}
> // create a mount point of multiple subclusters
> hdfs dfsrouteradmin -add /all_data ns1 /data1
> hdfs dfsrouteradmin -add /all_data ns2 /data2
> hdfs ec -Dfs.defaultFS=hdfs://router:8888 -setPolicy -path /all_data -policy
> RS-3-2-1024k
> Set RS-3-2-1024k erasure coding policy on /all_data
> hdfs ec -Dfs.defaultFS=hdfs://router:8888 -getPolicy -path /all_data
> RS-3-2-1024k
> hdfs ec -Dfs.defaultFS=hdfs://ns1-namenode:8020 -getPolicy -path /data1
> RS-3-2-1024k
> hdfs ec -Dfs.defaultFS=hdfs://ns2-namenode:8020 -getPolicy -path /data2
> The erasure coding policy of /data2 is unspecified
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
