[
https://issues.apache.org/jira/browse/HDFS-14226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768594#comment-16768594
]
Íñigo Goiri commented on HDFS-14226:
------------------------------------
Thanks [~ayushtkn] for [^HDFS-14226-HDFS-13891-04.patch].
In {{isInvokeConcurrent()}}, the javadoc comment has a weird syntax at the end
"or the if the source is a mount entry".
It also has some space before the comma in HASH_ALL.
To make it easier to read and have a comment I would do:
{code}
List<String> mountPoints = mountTableResolver.getMountPoints(path);
if (mountPoints != null) {
// If this is a mount point, we need to invoke everywhere
return true;
}
return isPathAll(path);
{code}
Then in the unit test I would explicitly check the path all:
{code}
@Test
public void testInvocationHashAllOrder() throws Exception {
setupOrderMountPath(DestinationOrder.HASH_ALL);
boolean isPathAll = rpcServer.isPathAll("/mnt/tmp")
assertTrue(isPathAll);
testInvocation(isPathAll);
}
{code}
Other than this small nits, I'm good with it.
Can others take a look? [~tasanuma0829]?
> RBF: Setting attributes should set on all subclusters' directories.
> -------------------------------------------------------------------
>
> Key: HDFS-14226
> URL: https://issues.apache.org/jira/browse/HDFS-14226
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Takanobu Asanuma
> Assignee: Ayush Saxena
> Priority: Major
> Labels: RBF
> Attachments: HDFS-14226-HDFS-13891-01.patch,
> HDFS-14226-HDFS-13891-02.patch, HDFS-14226-HDFS-13891-03.patch,
> HDFS-14226-HDFS-13891-04.patch, HDFS-14226-HDFS-13891-WIP1.patch
>
>
> Only one subcluster is set now.
> {noformat}
> // create a mount point of multiple subclusters
> hdfs dfsrouteradmin -add /all_data ns1 /data1
> hdfs dfsrouteradmin -add /all_data ns2 /data2
> hdfs ec -Dfs.defaultFS=hdfs://router:8888 -setPolicy -path /all_data -policy
> RS-3-2-1024k
> Set RS-3-2-1024k erasure coding policy on /all_data
> hdfs ec -Dfs.defaultFS=hdfs://router:8888 -getPolicy -path /all_data
> RS-3-2-1024k
> hdfs ec -Dfs.defaultFS=hdfs://ns1-namenode:8020 -getPolicy -path /data1
> RS-3-2-1024k
> hdfs ec -Dfs.defaultFS=hdfs://ns2-namenode:8020 -getPolicy -path /data2
> The erasure coding policy of /data2 is unspecified
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
