[ 
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767070#comment-16767070
 ] 

Brahma Reddy Battula commented on HDFS-13358:
---------------------------------------------

{quote}Could you please help me understand the requirement to add 
testDigestRPC? Auth is done at the SaslRpcServer layer which we haven't 
modified as part of this change. 
{quote}
Newly added test covers when AuthMethod is  KERBEROS so SASL authentication 
will be done through ** KERBEROS*.* As we added *TOKEN* impl (even ZKDTSM was 
already exists),SASL auth can be verified through TOKEN with ZKDTSM like 
following. I am ok to handle in followup jira
{code:java}
public void testDigest() throws Exception {
 TestingServer zkServer = new TestingServer();
 zkServer.start();
 String connectString = zkServer.getConnectString();
 Configuration conf = getSecretConf(connectString);
 conf.set(HADOOP_SECURITY_AUTHENTICATION, TOKEN.toString());
 RouterSecurityManager rm = new RouterSecurityManager(conf);
 SecurityUtil.setSecurityInfoProviders(new DelegationTokensecurityInfo());
 final Server server = new RPC.Builder(conf)
 .setProtocol(TestSaslProtocol.class).setInstance(new TestSaslImpl())
 .setBindAddress(ADDRESS).setPort(0).setNumHandlers(5).setVerbose(true)
 .setSecretManager(rm.getSecretManager()).build();
 doDigestRpc(server, rm);
}{code}
 

 Apart from the above Patch lgtm. Sorry for delayed review.

 

> RBF: Support for Delegation Token (RPC)
> ---------------------------------------
>
>                 Key: HDFS-13358
>                 URL: https://issues.apache.org/jira/browse/HDFS-13358
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Sherwood Zheng
>            Assignee: CR Hota
>            Priority: Major
>         Attachments: HDFS-13358-HDFS-13891.001.patch, 
> HDFS-13358-HDFS-13891.002.patch, HDFS-13358-HDFS-13891.003.patch, 
> HDFS-13358-HDFS-13891.004.patch, HDFS-13358-HDFS-13891.005.patch, 
> HDFS-13358-HDFS-13891.006.patch, HDFS-13358-HDFS-13891.007.patch, 
> HDFS-13358-HDFS-13891.008.patch, RBF_ Delegation token design.pdf
>
>
> HDFS Router should support issuing / managing HDFS delegation tokens.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to