[
https://issues.apache.org/jira/browse/HDDS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778016#comment-16778016
]
Elek, Marton commented on HDDS-1104:
------------------------------------
Thanks [~ljain] to fix this issue.
The patch looks good to me. I tested it and worked well. I will commit it soon.
I have two comments for the future (none of them is blocker, this patch is
definitely a good improvement. I add the following lines just for the sake of
the discussion).
1. Using patterns in \-benchmark
Sooner or later it will be hard to maintain the list of the available tests in
the annotation. We can store the class names in a list and support patterns in
the '-benchmark' parameter.
2. Usage of GenericCli
Usually we use GenericCli base class to support common command line parameters
with picocli. It could be useful here as well (eg. change rocksdb parameters)
but as I see the tests are created by jm base on class names and there is no
easy way to use the Configuration of the GenericCli in the Benchmark tests.
Don't know what can be the right approach here.
> Use picocli with Ozone genesis tool
> -----------------------------------
>
> Key: HDDS-1104
> URL: https://issues.apache.org/jira/browse/HDDS-1104
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Tools
> Reporter: Elek, Marton
> Assignee: Lokesh Jain
> Priority: Major
> Labels: newbie
> Attachments: HDDS-1104.001.patch
>
>
> Ozone genesis is a command line microbenchmark tool for ozone.
> With other ozone tools (eg with freon) we already switched to use picocli for
> command line argument parsing.
> It would be great to use picocli from org.apache.hadoop.ozone.genesis.Genesis
> as well.
> We need at least a "–filter" option to run only the filtered tests (this is a
> generic use case and the users usually comment out the unnecessary tests and
> the commented lines can be accidentally committed)
> Freon can be used as an example, but here we don't need any subcommands.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
