[ 
https://issues.apache.org/jira/browse/HDDS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778237#comment-16778237
 ] 

Lokesh Jain commented on HDDS-1104:
-----------------------------------

[~elek] Thanks for reporting, reviewing and committing the patch! :)

| Using patterns in -benchmark

I think its a good idea. Regarding the default list of benchmarks it just 
occurred to me that we can still create a default list of benchmarks class 
names and overwrite it if user provides a list. Although any new benchmarks 
would still need to be added in the description for -benchmark option. If this 
sounds right I can make this change as part of HDDS-1171.

| Usage of GenericCli

We can create a static configuration field in all the benchmarks and update it?

> Use picocli with Ozone genesis tool
> -----------------------------------
>
>                 Key: HDDS-1104
>                 URL: https://issues.apache.org/jira/browse/HDDS-1104
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Elek, Marton
>            Assignee: Lokesh Jain
>            Priority: Major
>              Labels: newbie
>             Fix For: 0.4.0
>
>         Attachments: HDDS-1104.001.patch
>
>
> Ozone genesis is a command line microbenchmark tool for ozone.
> With other ozone tools (eg with freon) we already switched to use picocli for 
> command line argument parsing.
> It would be great to use picocli from org.apache.hadoop.ozone.genesis.Genesis 
> as well.
> We need at least a "–filter" option to run only the filtered tests (this is a 
> generic use case and the users usually comment out the unnecessary tests and 
> the commented lines can be accidentally committed)
> Freon can be used as an example, but here we don't need any subcommands.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to