[
https://issues.apache.org/jira/browse/HDFS-14322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779947#comment-16779947
]
Íñigo Goiri commented on HDFS-14322:
------------------------------------
Thanks [~crh] for [^HDFS-14322-HDFS-13532.001.patch].
A couple comments:
* Change the order of the equals, as we know for sure that authMethodToInit
won't be null.
* Add a space between the if and the parenthesis.
* For the exception, instead of printing the whole cause, what about:
{{LOG.error("Could not instantiate {}: {}", clazz.getSimpleName(),
e.getCause().getMessage());}}. Or something that doesn't have a full stack
trace. The only issue is that right now we are using a precondition (throwing
NPE) for the ZK, maybe we want to throw a proper exception for that instead of
just relying on the precondition error. In any case, {{Zookeeper connection
string cannot be null}} is ok as a message.
> RBF: Security manager should not load if security is disabled
> -------------------------------------------------------------
>
> Key: HDFS-14322
> URL: https://issues.apache.org/jira/browse/HDFS-14322
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: CR Hota
> Assignee: CR Hota
> Priority: Major
> Attachments: HDFS-14322-HDFS-13532.001.patch
>
>
> Security manager tries to instantiate secret manager irrespective of whether
> security is on/off. Simple optimization should be done to avoid loading
> secret manager if security is turned off.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
