[
https://issues.apache.org/jira/browse/HDFS-14322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779958#comment-16779958
]
CR Hota commented on HDFS-14322:
--------------------------------
[~elgoiri] Thanks for the quick review.
# Thought about ordering, kept it this way as
SecurityUtil.getAuthenticationMethod always returns a default if not set. Can
change the order here.
# Sorry missed the space.
# For exception itself, I think it's better to leave it with the whole stack
trace instead of single error line for easy debuggability. This exception is
only going to be shown in case security is enabled and init of secret manager
has a real issue. While running unit tests itself I realized that seeing the
actual stack in front is easy to trace the issue origin. Now that we are not
initializing when security if off, this issue should be clearly shown as a
stack trace in the logs for users. Thoughts?
> RBF: Security manager should not load if security is disabled
> -------------------------------------------------------------
>
> Key: HDFS-14322
> URL: https://issues.apache.org/jira/browse/HDFS-14322
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: CR Hota
> Assignee: CR Hota
> Priority: Major
> Attachments: HDFS-14322-HDFS-13532.001.patch
>
>
> Security manager tries to instantiate secret manager irrespective of whether
> security is on/off. Simple optimization should be done to avoid loading
> secret manager if security is turned off.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
