[
https://issues.apache.org/jira/browse/HDDS-594?focusedWorklogId=208113&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-208113
]
ASF GitHub Bot logged work on HDDS-594:
---------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/19 22:08
Start Date: 05/Mar/19 22:08
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #547: HDDS-594. SCM
CA: DN sends CSR and uses certificate issued by SCM.
URL: https://github.com/apache/hadoop/pull/547#discussion_r262568472
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java
##########
@@ -252,38 +250,37 @@ public void
initializeCertificateClient(OzoneConfiguration config)
/**
* Get SCM signed certificate and store it using certificate client.
+ * @param client
+ * @param config
* */
private void getSCMSignedCert(CertificateClient client,
OzoneConfiguration config) throws IOException {
+ PKCS10CertificationRequest csr = getCSR(client, config);
+ SCMSecurityProtocol secureScmClient =
+ HddsUtils.getScmSecurityClient(config,
+ HddsUtils.getScmAddressForSecurityProtocol(config));
- for (EndpointStateMachine ep : datanodeStateMachine.getConnectionManager()
- .getValues()) {
- PKCS10CertificationRequest csr = getCSR(client, config, ep.getVersion());
- SCMSecurityProtocol secureScmClient =
- HddsUtils.getScmSecurityClient(config, ep.getAddress());
+ String pemEncodedCert = secureScmClient.getDataNodeCertificate(
+ datanodeDetails.getProtoBufMessage(), getEncodedString(csr));
- String pemEncodedCert = secureScmClient.getDataNodeCertificate(
- datanodeDetails.getProtoBufMessage(), getEncodedString(csr));
-
- try {
- X509Certificate x509Certificate =
- CertificateCodec.getX509Certificate(pemEncodedCert);
- client.storeCertificate(x509Certificate);
- } catch (IOException | CertificateException e) {
- LOG.error("Error while storing SCM signed certificate.", e);
- throw new RuntimeException(e);
Review comment:
Should we throw RetriableException instead of RuntimeException so that DN
can retry if SCM is not available (e.g., reboot, not fully boot up yet)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 208113)
Time Spent: 1h 50m (was: 1h 40m)
> SCM CA: DN sends CSR and uses certificate issued by SCM
> -------------------------------------------------------
>
> Key: HDDS-594
> URL: https://issues.apache.org/jira/browse/HDDS-594
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Labels: pull-request-available
> Attachments: HDDS-594.00.patch, HDDS-594.01.patch, HDDS-594.02.patch,
> HDDS-594.03.patch
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
