[
https://issues.apache.org/jira/browse/HDDS-594?focusedWorklogId=208116&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-208116
]
ASF GitHub Bot logged work on HDDS-594:
---------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/19 22:08
Start Date: 05/Mar/19 22:08
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #547: HDDS-594. SCM
CA: DN sends CSR and uses certificate issued by SCM.
URL: https://github.com/apache/hadoop/pull/547#discussion_r262569791
##########
File path:
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/TestHddsSecureDatanodeInit.java
##########
@@ -252,23 +251,17 @@ public static void callQuietly(Callable closure) {
public void testGetCSR() throws Exception {
keyCodec.writePublicKey(publicKey);
keyCodec.writePrivateKey(privateKey);
- VersionResponse versionResponse = VersionResponse
- .newBuilder()
- .setVersion(0)
- .addValue(OzoneConsts.SCM_ID, "123")
- .addValue(OzoneConsts.CLUSTER_ID, "123")
- .build();
PKCS10CertificationRequest csr =
- service.getCSR(client, conf, versionResponse);
+ service.getCSR(client, conf);
Review comment:
Given that we remove the SCM_ID/CLUSTER_ID from the CSR, can we assert the
certificate returned contains a valid SCM_ID and CLUSTER_ID here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 208116)
Time Spent: 2h 10m (was: 2h)
> SCM CA: DN sends CSR and uses certificate issued by SCM
> -------------------------------------------------------
>
> Key: HDDS-594
> URL: https://issues.apache.org/jira/browse/HDDS-594
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Labels: pull-request-available
> Attachments: HDDS-594.00.patch, HDDS-594.01.patch, HDDS-594.02.patch,
> HDDS-594.03.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
