[
https://issues.apache.org/jira/browse/HDDS-1217?focusedWorklogId=209321&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-209321
]
ASF GitHub Bot logged work on HDDS-1217:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Mar/19 02:55
Start Date: 07/Mar/19 02:55
Worklog Time Spent: 10m
Work Description: swagle commented on pull request #558: HDDS-1217.
Refactor ChillMode rules and chillmode manager.
URL: https://github.com/apache/hadoop/pull/558#discussion_r263220972
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/chillmode/ContainerChillModeRule.java
##########
@@ -46,14 +46,20 @@
private double maxContainer;
private AtomicLong containerWithMinReplicas = new AtomicLong(0);
- private final SCMChillModeManager chillModeManager;
- public ContainerChillModeRule(Configuration conf,
+ public ContainerChillModeRule(String ruleName, EventQueue eventQueue,
+ Configuration conf,
List<ContainerInfo> containers, SCMChillModeManager manager) {
+ super(manager, ruleName);
chillModeCutoff = conf.getDouble(
HddsConfigKeys.HDDS_SCM_CHILLMODE_THRESHOLD_PCT,
HddsConfigKeys.HDDS_SCM_CHILLMODE_THRESHOLD_PCT_DEFAULT);
- chillModeManager = manager;
+
+ if (chillModeCutoff > 1.0 || chillModeCutoff < 0.0) {
Review comment:
FFT: Guava preconditions might improve readability here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 209321)
Time Spent: 1h (was: 50m)
> Refactor ChillMode rules and chillmode manager
> ----------------------------------------------
>
> Key: HDDS-1217
> URL: https://issues.apache.org/jira/browse/HDDS-1217
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> # Make the chillmodeExitRule abstract class and move common logic for all
> rules into this.
> # Update test's for chill mode accordingly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
