[
https://issues.apache.org/jira/browse/HDDS-1217?focusedWorklogId=214644&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214644
]
ASF GitHub Bot logged work on HDDS-1217:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/19 09:09
Start Date: 18/Mar/19 09:09
Worklog Time Spent: 10m
Work Description: nandakumar131 commented on pull request #558:
HDDS-1217. Refactor ChillMode rules and chillmode manager.
URL: https://github.com/apache/hadoop/pull/558#discussion_r266346041
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/chillmode/ChillModeExitRule.java
##########
@@ -17,16 +17,87 @@
*/
package org.apache.hadoop.hdds.scm.chillmode;
+import org.apache.hadoop.hdds.server.events.EventHandler;
+import org.apache.hadoop.hdds.server.events.EventPublisher;
+
+
/**
- * Interface for defining chill mode exit rules.
+ * Abstract class for ChillModeExitRules. When a new rule is added, the new
+ * rule should extend this abstract class.
+ *
+ * Each rule Should do:
+ * 1. Should add a handler for the event it is looking for during the
+ * initialization of the rule.
+ * 2. Add the rule in ScmChillModeManager to list of the rules.
+ *
*
* @param <T>
*/
-public interface ChillModeExitRule<T> {
+public abstract class ChillModeExitRule<T> implements EventHandler<T> {
+
+ private final SCMChillModeManager chillModeManager;
+ private final String ruleName;
+
+ public ChillModeExitRule(SCMChillModeManager chillModeManager,
+ String ruleName) {
+ this.chillModeManager = chillModeManager;
+ this.ruleName = ruleName;
+ }
+
+ /**
+ * Return's the name of this ChillModeExit Rule.
+ * @return ruleName
+ */
+ public String getRuleName() {
+ return ruleName;
+ }
+
+
+ /**
+ * Validate's this rule. If this rule condition is met, returns true, else
+ * returns false.
+ * @return boolean
+ */
+ public abstract boolean validate();
+
+ /**
+ * Actual processing logic for this rule.
+ * @param report
+ */
+ public abstract void process(T report);
Review comment:
This can also be protected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 214644)
Time Spent: 2h 20m (was: 2h 10m)
> Refactor ChillMode rules and chillmode manager
> ----------------------------------------------
>
> Key: HDDS-1217
> URL: https://issues.apache.org/jira/browse/HDDS-1217
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> # Make the chillmodeExitRule abstract class and move common logic for all
> rules into this.
> # Update test's for chill mode accordingly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
