[
https://issues.apache.org/jira/browse/HDDS-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786538#comment-16786538
]
Shashikant Banerjee commented on HDDS-1095:
-------------------------------------------
Thanks [~msingh] for updating the patch. Some comments:
1) Let's have a limit on the no of blocks allocated per allocate block rpc call
to SCM.(We can cap it to be 5GB which is our container size)
2) The error code "Unknown" does not seem to be convey any useful message here.
Can we make it more meaningful?
{noformat}
if (allocatedBlocks.size() < request.getNumBlocks()) {
return builder
.setErrorCode(AllocateScmBlockResponseProto.Error.unknownFailure)
.build();
}{noformat}
> OzoneManager#openKey should do multiple block allocations in a single SCM rpc
> call
> ----------------------------------------------------------------------------------
>
> Key: HDDS-1095
> URL: https://issues.apache.org/jira/browse/HDDS-1095
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Affects Versions: 0.4.0
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Major
> Fix For: 0.4.0
>
> Attachments: HDDS-1095.001.patch, HDDS-1095.002.patch,
> HDDS-1095.003.patch
>
>
> Currently in KeyManagerImpl#openKey, for a large key allocation, multiple
> blocks are allocated in different rpc calls. If the key length is already
> known, then multiple blocks can be allocated in one rpc call to SCM.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
