[
https://issues.apache.org/jira/browse/HDDS-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790394#comment-16790394
]
Lokesh Jain commented on HDDS-1095:
-----------------------------------
[~msingh] Thanks for updating the patch! The path looks good to me. I have a
few minor comments.
# In ScmBlockLocationProtocolServerSideTranslatorPB, we should return the
blocks in the response proto even if they are less than the requested number of
blocks. Also can we add another error code for this situation?
# ScmBlockLocationProtocolClientSideTranslatorPB:114 - We can initialise the
array list with the received number of blocks.
# SCMBlockProtocolServer:167 - Same as above.
> OzoneManager#openKey should do multiple block allocations in a single SCM rpc
> call
> ----------------------------------------------------------------------------------
>
> Key: HDDS-1095
> URL: https://issues.apache.org/jira/browse/HDDS-1095
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Affects Versions: 0.4.0
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Major
> Fix For: 0.4.0
>
> Attachments: HDDS-1095.001.patch, HDDS-1095.002.patch,
> HDDS-1095.003.patch, HDDS-1095.004.patch, HDDS-1095.005.patch,
> HDDS-1095.006.patch
>
>
> Currently in KeyManagerImpl#openKey, for a large key allocation, multiple
> blocks are allocated in different rpc calls. If the key length is already
> known, then multiple blocks can be allocated in one rpc call to SCM.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
