[
https://issues.apache.org/jira/browse/HDFS-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789632#comment-16789632
]
Rakesh R commented on HDFS-14354:
---------------------------------
Good work, [~PhiloHe]. I've submitted patch to get QA report. Please take care
{{checkstyle}} warnings.
Adding few comments on patch:
# Please add javadoc to {{MappableBlockLoader}} abstract class.
# MappableBlockLoader.java - '{{mmap and mlock the block, and then verify its
checksum'}} please change it to '{{mmap the block, and then verify its
checksum'}} as mlock is very specific to Memory.
# FsDatasetCache.java - Please remove the unused method. Will add this later
when you add unit testcases and that time will review the necessity of exposing
this.
{code:java}
+import com.google.common.annotations.VisibleForTesting;
....
....
+
+ @VisibleForTesting
+ public MappableBlockLoader getMappableBlockLoader() {
+ return mappableBlockLoader;
+ }
{code}
# Any specific reason to remove the {{return;}} statement. If not, please keep
the existing behavior.
{code:java}
} catch (ChecksumException e) {
// Exception message is bogus since this wasn't caused by a file read
LOG.warn("Failed to cache " + key + ": checksum verification failed.");
- return;
{code}
> Refactor MappableBlock to align with the implementation of SCM cache
> --------------------------------------------------------------------
>
> Key: HDFS-14354
> URL: https://issues.apache.org/jira/browse/HDFS-14354
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: caching, datanode
> Reporter: Feilong He
> Assignee: Feilong He
> Priority: Major
> Attachments: HDFS-14354.000.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
