[
https://issues.apache.org/jira/browse/HDFS-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792381#comment-16792381
]
Uma Maheswara Rao G commented on HDFS-14354:
--------------------------------------------
[~PhiloHe] Thanks for working on it and Thanks [~rakeshr] for the review.
I have one small nit:
{code:java}
@Override
48 public void afterCache() {
49 // Nothing to do after block is cached to memory
50 }
{code}
Could you please remove this from this patch. You should add only when this is
needed. So, you could add in later patches if needed.
> Refactor MappableBlock to align with the implementation of SCM cache
> --------------------------------------------------------------------
>
> Key: HDFS-14354
> URL: https://issues.apache.org/jira/browse/HDFS-14354
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: caching, datanode
> Reporter: Feilong He
> Assignee: Feilong He
> Priority: Major
> Attachments: HDFS-14354.000.patch, HDFS-14354.001.patch,
> HDFS-14354.002.patch, HDFS-14354.003.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
