[ 
https://issues.apache.org/jira/browse/HDFS-14388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799520#comment-16799520
 ] 

Ayush Saxena commented on HDFS-14388:
-------------------------------------

Thanx [~elgoiri] for the patch.

Just one minor doubt:

 
{code:java}
 protected StateStoreMetrics() {}
{code}
Can package level access modifier(default/no modifier) work? or protected is 
needed for some porpose.

Other than this LGTM. :)

 

> RBF: Prevent loading metric system when disabled
> ------------------------------------------------
>
>                 Key: HDFS-14388
>                 URL: https://issues.apache.org/jira/browse/HDFS-14388
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Íñigo Goiri
>            Priority: Major
>         Attachments: HDFS-14388-HDFS-13891.000.patch, 
> HDFS-14388-HDFS-13891.001.patch
>
>
> Currently, the Router and the State Store try to initialize the metrics even 
> when they are specially disabled. This produces a lot of verbose logs in 
> tests without metrics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to