[
https://issues.apache.org/jira/browse/HDFS-14388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799555#comment-16799555
]
Íñigo Goiri commented on HDFS-14388:
------------------------------------
Thanks [~ayushtkn] for the comment.
The main issue is that if I want to create a subclass with an empty
constructor, I need to refer to the parent class.
I guess I can use package modified (aka, no modified) but not sure if there is
a fundamental advantage between protected and no modifier.
At some point, I was tempted to use a mock of a {{StateStoreMetrics}} and avoid
the new {{NullStateStoreMetrics}} but it didn't look clean to me.
> RBF: Prevent loading metric system when disabled
> ------------------------------------------------
>
> Key: HDFS-14388
> URL: https://issues.apache.org/jira/browse/HDFS-14388
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Íñigo Goiri
> Priority: Major
> Attachments: HDFS-14388-HDFS-13891.000.patch,
> HDFS-14388-HDFS-13891.001.patch
>
>
> Currently, the Router and the State Store try to initialize the metrics even
> when they are specially disabled. This produces a lot of verbose logs in
> tests without metrics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
