[
https://issues.apache.org/jira/browse/HDDS-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801373#comment-16801373
]
Mukul Kumar Singh commented on HDDS-1300:
-----------------------------------------
Thanks for working on this [~ljain]. The patch generally looks good to me. Some
comments as following.
1) There are findbugs & unit test failures related to the patch.
2) For createDirectory, should we pass the replication type and factor ? so
that these values can be populated correctly for getFileStatus?
3) KeyManagerImpl:1366, OzoneFileSystem should append a "/" to the path and
send this to OM. Is this needed for other cases ?
4) KeyManagerImpl:1395. lets rename this to create/createFile to follow the
same naming convention as OzoneFilesystem. The same for lookupFile on line 1443
as well.
5) KeyManagerImpl:535, as this is only used to create directory Key, should
this be renamed to createDirectoryKeyInfo, also is setting OmKeyLocations
required ?
6) OzoneClientAdapter:49, this can be removed as well.
7) OzoneFileSystem.java:240-248, should we push the exception handling inside
the OzoneClientApapterImpl ?
8) OzoneFileSystem:765, an extra printStackTrace
9) OzoneManager.java:2641, GET_FILE_STATUS -> CREATE_DIRECTORY
10) OzoneManagerProtocol.proto, lets add a CreateDirectoryResponse, even though
we keep it empty. Lets do this so 1-1 mapping for requests vs response protos
11) RpcClient.java:931, 938, the indendation for @Override flag is off.
> Optimize non-recursive ozone filesystem apis
> --------------------------------------------
>
> Key: HDDS-1300
> URL: https://issues.apache.org/jira/browse/HDDS-1300
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Filesystem, Ozone Manager
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Attachments: HDDS-1300.001.patch, HDDS-1300.002.patch,
> HDDS-1300.003.patch
>
>
> This Jira aims to optimise non recursive apis in ozone file system. The Jira
> would add support for such apis in Ozone manager in order to reduce the
> number of rpc calls to Ozone Manager.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
