[
https://issues.apache.org/jira/browse/HDDS-1262?focusedWorklogId=218956&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-218956
]
ASF GitHub Bot logged work on HDDS-1262:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Mar/19 21:54
Start Date: 26/Mar/19 21:54
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #626:
HDDS-1262. In OM HA OpenKey and initiateMultipartUpload call Should happen only
leader OM.
URL: https://github.com/apache/hadoop/pull/626#discussion_r269331803
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -1985,6 +1990,51 @@ public OpenKeySession openKey(OmKeyArgs args) throws
IOException {
}
}
+ @Override
+ public void applyOpenKey(KeyArgs omKeyArgs, KeyInfo keyInfo, long clientID)
+ throws IOException {
+ // Do we need to check again Acl's for apply OpenKey call?
+ if(isAclEnabled) {
+ checkAcls(ResourceType.KEY, StoreType.OZONE, ACLType.READ,
+ omKeyArgs.getVolumeName(), omKeyArgs.getBucketName(),
+ omKeyArgs.getKeyName());
+ }
+ boolean auditSuccess = true;
+ try {
+ keyManager.applyOpenKey(omKeyArgs, keyInfo, clientID);
+ } catch (Exception ex) {
+ metrics.incNumKeyAllocateFails();
+ auditSuccess = false;
+ AUDIT.logWriteFailure(buildAuditMessageForFailure(
+ OMAction.APPLY_ALLOCATE_KEY,
+ (omKeyArgs == null) ? null : toAuditMap(omKeyArgs), ex));
+ throw ex;
+ } finally {
+ if(auditSuccess){
+ AUDIT.logWriteSuccess(buildAuditMessageForSuccess(
+ OMAction.ALLOCATE_KEY, (omKeyArgs == null) ? null :
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 218956)
Time Spent: 3h 10m (was: 3h)
> In OM HA OpenKey call Should happen only leader OM
> --------------------------------------------------
>
> Key: HDDS-1262
> URL: https://issues.apache.org/jira/browse/HDDS-1262
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> In OM HA, currently, when openKey is called, in applyTransaction() on all OM
> nodes, we make a call to SCM and write the allocateBlock information into OM
> DB and also clientID will be generated by each OM node.
>
> The proposed approach is:
> 1. In startTransaction, call openKey and the response returned should be used
> to create a new OmRequest object and used in setting the transaction context.
> And also modify the ozoneManager and KeymanagerImpl to handle the code with
> and without ratis.
>
> This Jira also implements HDDS-1319.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
