[ 
https://issues.apache.org/jira/browse/HDDS-1262?focusedWorklogId=218959&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-218959
 ]

ASF GitHub Bot logged work on HDDS-1262:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Mar/19 21:55
            Start Date: 26/Mar/19 21:55
    Worklog Time Spent: 10m 
      Work Description: bharatviswa504 commented on pull request #626: 
HDDS-1262. In OM HA OpenKey and initiateMultipartUpload call Should happen only 
leader OM.
URL: https://github.com/apache/hadoop/pull/626#discussion_r269330512
 
 

 ##########
 File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java
 ##########
 @@ -181,6 +297,17 @@ private TransactionContext handleAllocateBlock(
 
   }
 
+  /**
+   * Construct IOException message for failed requests in StartTransaction.
+   * @param omResponse
+   * @return
+   */
+  private IOException constructExceptionForFailedRequest(
+      OMResponse omResponse) {
+    return new IOException(omResponse.getMessage() + " " +
+        STATUS_CODE + omResponse.getStatus());
+  }
 
 Review comment:
   I tried that way, as this is converted to IOException somewhere in Ratis 
end, I am not able to do that. Initially I have tried the way you have 
suggested and figured out it is not working.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 218959)
    Time Spent: 3h 40m  (was: 3.5h)

> In OM HA OpenKey call Should happen only leader OM
> --------------------------------------------------
>
>                 Key: HDDS-1262
>                 URL: https://issues.apache.org/jira/browse/HDDS-1262
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> In OM HA, currently, when openKey is called, in applyTransaction() on all OM 
> nodes, we make a call to SCM and write the allocateBlock information into OM 
> DB and also clientID will be generated by each OM node.
>  
> The proposed approach is:
> 1. In startTransaction, call openKey and the response returned should be used 
> to create a new OmRequest object and used in setting the transaction context. 
> And also modify the ozoneManager and KeymanagerImpl to handle the code with 
> and without ratis.
>  
> This Jira also implements HDDS-1319. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to