[
https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=220482&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-220482
]
ASF GitHub Bot logged work on HDDS-976:
---------------------------------------
Author: ASF GitHub Bot
Created on: 29/Mar/19 10:40
Start Date: 29/Mar/19 10:40
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #661: HDDS-976: Parse
network topology from yaml file
URL: https://github.com/apache/hadoop/pull/661#issuecomment-477951801
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 39 | Docker mode activated. |
||| _ Prechecks _ |
| 0 | yamllint | 0 | yamllint was not available. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 4 new or modified test
files. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 1237 | trunk passed |
| +1 | compile | 59 | trunk passed |
| +1 | checkstyle | 19 | trunk passed |
| +1 | mvnsite | 40 | trunk passed |
| +1 | shadedclient | 774 | branch has no errors when building and testing
our client artifacts. |
| +1 | findbugs | 74 | trunk passed |
| +1 | javadoc | 40 | trunk passed |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 51 | the patch passed |
| +1 | compile | 35 | the patch passed |
| +1 | javac | 35 | the patch passed |
| -0 | checkstyle | 16 | hadoop-hdds/common: The patch generated 13 new + 0
unchanged - 0 fixed = 13 total (was 0) |
| +1 | mvnsite | 42 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | xml | 1 | The patch has no ill-formed XML file. |
| +1 | shadedclient | 820 | patch has no errors when building and testing
our client artifacts. |
| -1 | findbugs | 79 | hadoop-hdds/common generated 1 new + 0 unchanged - 0
fixed = 1 total (was 0) |
| +1 | javadoc | 35 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 79 | common in the patch failed. |
| +1 | asflicense | 25 | The patch does not generate ASF License warnings. |
| | | 3547 | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-hdds/common |
| |
org.apache.hadoop.hdds.scm.net.NodeSchemaLoader.loadSchemaFromYaml(File) may
fail to clean up java.io.InputStream Obligation to clean up resource created
at NodeSchemaLoader.java:up java.io.InputStream Obligation to clean up
resource created at NodeSchemaLoader.java:[line 208] is not discharged |
| Failed junit tests | hadoop.hdds.scm.net.TestNetworkTopologyImpl |
| | hadoop.hdds.scm.net.TestNodeSchemaManager |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-661/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/661 |
| JIRA Issue | HDDS-976 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml findbugs checkstyle yamllint |
| uname | Linux 6a50ad832710 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri
Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / f41f938 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-661/1/artifact/out/diff-checkstyle-hadoop-hdds_common.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-661/1/artifact/out/new-findbugs-hadoop-hdds_common.html
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-661/1/artifact/out/patch-unit-hadoop-hdds_common.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-661/1/testReport/ |
| Max. process+thread count | 304 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common U: hadoop-hdds/common |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-661/1/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 220482)
Time Spent: 20m (was: 10m)
> Support YAML format network topology cluster definition
> -------------------------------------------------------
>
> Key: HDDS-976
> URL: https://issues.apache.org/jira/browse/HDDS-976
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Sammi Chen
> Assignee: Junjie Chen
> Priority: Major
> Labels: pull-request-available
> Attachments: NetworkTopologyDefault.yaml
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
