[
https://issues.apache.org/jira/browse/HDDS-976?focusedWorklogId=222791&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222791
]
ASF GitHub Bot logged work on HDDS-976:
---------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/19 04:00
Start Date: 04/Apr/19 04:00
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #661: HDDS-976:
Parse network topology from yaml file
URL: https://github.com/apache/hadoop/pull/661#discussion_r272010041
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NodeSchemaManager.java
##########
@@ -59,13 +59,20 @@ public void init(Configuration conf) {
/**
* Load schemas from network topology schema configuration file
*/
+ String schemaFileType = conf.get(
+ ScmConfigKeys.OZONE_SCM_NETWORK_TOPOLOGY_SCHEMA_FILE_TYPE);
+
String schemaFile = conf.get(
ScmConfigKeys.OZONE_SCM_NETWORK_TOPOLOGY_SCHEMA_FILE,
ScmConfigKeys.OZONE_SCM_NETWORK_TOPOLOGY_SCHEMA_FILE_DEFAULT);
NodeSchemaLoadResult result;
try {
- result = NodeSchemaLoader.getInstance().loadSchemaFromFile(schemaFile);
+ if (schemaFileType.compareTo("yaml") == 0) {
Review comment:
Can we make the schema type string case insensitive?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 222791)
Time Spent: 1h 10m (was: 1h)
> Support YAML format network topology cluster definition
> -------------------------------------------------------
>
> Key: HDDS-976
> URL: https://issues.apache.org/jira/browse/HDDS-976
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Sammi Chen
> Assignee: Junjie Chen
> Priority: Major
> Labels: pull-request-available
> Attachments: NetworkTopologyDefault.yaml
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
