[
https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805093#comment-16805093
]
Yiqun Lin commented on HDDS-1189:
---------------------------------
Thanks for addressing the comment, [~swagle]. Some minor comments:
1.
{code}
public static void main(String[] args) {
+ if (args.length < 1) {
+ throw new ExceptionInInitializerError("Missing required arguments: " +
+ "Need a ouput directory for generated code.\nUsage: " +
+ "org.apache.hadoop.ozone.recon.persistence.JooqCodeGenerator " +
+ "<outputDirectory>.");
+ }
+
...
+ // Cleanup resources
+ LocalDataSourceProvider.cleanup();
+ }
{code}
{quote}
Can I understand this as the test program? If so, how about move this logic
into an independent unit test?
{quote}
Can you confirm this if I understand correctly?
2. Add new settings in ozone-default.xml, otherwise it will lead the failure of
{{hadoop.ozone.TestOzoneConfigurationFields}}.
3. Some whitespaces warnings need to be fixed.
> Recon Aggregate DB schema and ORM
> ---------------------------------
>
> Key: HDDS-1189
> URL: https://issues.apache.org/jira/browse/HDDS-1189
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Affects Versions: 0.5.0
> Reporter: Siddharth Wagle
> Assignee: Siddharth Wagle
> Priority: Major
> Fix For: 0.5.0
>
> Attachments: HDDS-1189.01.patch, HDDS-1189.02.patch,
> HDDS-1189.03.patch
>
>
> _Objectives_
> - Define V1 of the db schema for recon service
> - The current proposal is to use jOOQ as the ORM for SQL interaction. For two
> main reasons: a) powerful DSL for querying, that abstracts out SQL dialects,
> b) Allows code to schema and schema to code seamless transition, critical for
> creating DDL through the code and unit testing across versions of the
> application.
> - Add e2e unit tests suite for Recon entities, created based on the design doc
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
