[
https://issues.apache.org/jira/browse/HDDS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805833#comment-16805833
]
Aravindan Vijayan commented on HDDS-1189:
-----------------------------------------
I think the patch looks great! Minor comments.
1.
{code}
<name>ozone.recon.sql.db.jdbc.url</name>
<value>jdbc:sqlite:/tmp/ozone_recon_sqlite.db</value>
{code}
Is this value just the default? It may be preferable to have the Recon SQL DB
in the same metadata dir as container DB.
2.
{code}
<name>ozone.recon.sql.db.password</name>
{code}
Can we specify this as password field?
3. In the findbugs exclude file, why are we adding the package
"org.hadoop.ozone.recon.schema" even after adding the child packages like
org.hadoop.ozone.recon.schema.tables and
org.hadoop.ozone.recon.schema.tables.pojos?
> Recon Aggregate DB schema and ORM
> ---------------------------------
>
> Key: HDDS-1189
> URL: https://issues.apache.org/jira/browse/HDDS-1189
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Affects Versions: 0.5.0
> Reporter: Siddharth Wagle
> Assignee: Siddharth Wagle
> Priority: Major
> Fix For: 0.5.0
>
> Attachments: HDDS-1189.01.patch, HDDS-1189.02.patch,
> HDDS-1189.03.patch, HDDS-1189.04.patch
>
>
> _Objectives_
> - Define V1 of the db schema for recon service
> - The current proposal is to use jOOQ as the ORM for SQL interaction. For two
> main reasons: a) powerful DSL for querying, that abstracts out SQL dialects,
> b) Allows code to schema and schema to code seamless transition, critical for
> creating DDL through the code and unit testing across versions of the
> application.
> - Add e2e unit tests suite for Recon entities, created based on the design doc
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
