[ 
https://issues.apache.org/jira/browse/HDDS-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810704#comment-16810704
 ] 

Lokesh Jain commented on HDDS-1294:
-----------------------------------

[~shashikant] Thanks for working on this! The patch looks good to me. Please 
find my comments below.
 # ExcludeList.java - We should synchronize getProtobuf and getPipelineIds 
calls as well.
 # TestCloseContainerHandlingByClient#testContainerExclusionWithMultipleClients 
: We should remove the ignore annotation and rename the function to 
testContainerExclusionWithMultiple"Streams".

> ExcludeList shoud be a RPC Client config so that multiple streams can avoid 
> the same error.
> -------------------------------------------------------------------------------------------
>
>                 Key: HDDS-1294
>                 URL: https://issues.apache.org/jira/browse/HDDS-1294
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Client
>    Affects Versions: 0.4.0
>            Reporter: Mukul Kumar Singh
>            Assignee: Shashikant Banerjee
>            Priority: Major
>              Labels: MiniOzoneChaosCluster
>         Attachments: HDDS-1294.000.patch
>
>
> ExcludeList right now is a per BlockOutPutStream value, this can result in 
> multiple keys created out of the same client to run into same exception



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to