[ 
https://issues.apache.org/jira/browse/HDDS-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813081#comment-16813081
 ] 

Jitendra Nath Pandey commented on HDDS-1294:
--------------------------------------------

# DistributedStorageHandler is a long lived object. The exclude list from this 
will never get cleaned up.
# {code:java}
public List<PipelineID> getPipelineIds() {
  return Collections.synchronizedList(pipelineIds);
}{code}
What is the need for returning synchronizedList? I think the problem is that 
same class is used at client to update, and also at the SCM to iterate. 
# In {{TestCloseContainerHandlingByClient}}, since we are trying to detect 
issues with potential race conditions, you might want to create 10 threads in a 
loop to increase the concurrency.



> ExcludeList shoud be a RPC Client config so that multiple streams can avoid 
> the same error.
> -------------------------------------------------------------------------------------------
>
>                 Key: HDDS-1294
>                 URL: https://issues.apache.org/jira/browse/HDDS-1294
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Client
>    Affects Versions: 0.4.0
>            Reporter: Mukul Kumar Singh
>            Assignee: Shashikant Banerjee
>            Priority: Major
>              Labels: MiniOzoneChaosCluster
>         Attachments: HDDS-1294.000.patch, HDDS-1294.001.patch
>
>
> ExcludeList right now is a per BlockOutPutStream value, this can result in 
> multiple keys created out of the same client to run into same exception



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to