[
https://issues.apache.org/jira/browse/HDFS-13909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816594#comment-16816594
]
Íñigo Goiri commented on HDFS-13909:
------------------------------------
Thanks [~ayushtkn] for taking over.
It looks like we are using the same pattern all the time and it actually looks
like a combination between invokeSequential and invokeConcurrent.
I would propose to use invokeAll (or an extensions) this should give you the
first exception too.
Even if invokeAll doesn't match exactly, let's try to figure a wrapper for all
these methods.
For the test, I'm not very familiar with the cache APIs so I cannot go too deep
but it looks a decent coverage.
I would improve readability by adding general blocks with comments.
For the builder pattern we may want to do:
{code}
cacheDir = new CacheDirectiveInfo.Builder()
.setReplication((short) 2)
.setId(id)
.setPath(new Path("/ns1/dir"))
.build();
{code}
Wait for Yetus too as there are a few checkstyle issues here.
> RBF: Add Cache pools and directives related ClientProtocol apis
> ---------------------------------------------------------------
>
> Key: HDFS-13909
> URL: https://issues.apache.org/jira/browse/HDFS-13909
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Dibyendu Karmakar
> Assignee: Dibyendu Karmakar
> Priority: Major
> Attachments: HDFS-13909-HDFS-13891-01.patch
>
>
> Currently addCachePool, modifyCachePool, removeCachePool, listCachePools,
> addCacheDirective, modifyCacheDirective, removeCacheDirective,
> listCacheDirectives these APIs are not implemented in Router.
> This JIRA is intend to implement above mentioned APIs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
