[
https://issues.apache.org/jira/browse/HDDS-1456?focusedWorklogId=232485&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-232485
]
ASF GitHub Bot logged work on HDDS-1456:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/19 01:57
Start Date: 25/Apr/19 01:57
Worklog Time Spent: 10m
Work Description: arp7 commented on pull request #769: HDDS-1456. Stop
the datanode, when any datanode statemachine state is…
URL: https://github.com/apache/hadoop/pull/769#discussion_r278374738
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java
##########
@@ -93,7 +95,9 @@
* enabled
*/
public DatanodeStateMachine(DatanodeDetails datanodeDetails,
- Configuration conf, CertificateClient certClient) throws IOException {
+ Configuration conf, CertificateClient certClient,
Review comment:
It also feels unfortunate that we have to pass this back-reference.
StateMachine should not really know about HddsDataNodeService. Now we have a
circular dependency.
Can we instead pass a callback via method reference that should be invoked
when termination is necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 232485)
Time Spent: 50m (was: 40m)
> Stop the datanode, when any datanode statemachine state is set to shutdown
> --------------------------------------------------------------------------
>
> Key: HDDS-1456
> URL: https://issues.apache.org/jira/browse/HDDS-1456
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Recently we have seen an issue, in InitDatanodeState, there is error during
> create Path for volume. We set the state to shutdown and this has caused
> DatanodeStateMachine to stop, but datanode is still running. In this case we
> should stop Datanode, otherwise, user will know about this when running ozone
> commands or when user observed metrics like healthy nodes.
>
> cc [~vivekratnavel]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
