[ 
https://issues.apache.org/jira/browse/HDDS-1456?focusedWorklogId=232536&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-232536
 ]

ASF GitHub Bot logged work on HDDS-1456:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Apr/19 04:23
            Start Date: 25/Apr/19 04:23
    Worklog Time Spent: 10m 
      Work Description: bharatviswa504 commented on pull request #769: 
HDDS-1456. Stop the datanode, when any datanode statemachine state is…
URL: https://github.com/apache/hadoop/pull/769#discussion_r278392038
 
 

 ##########
 File path: 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java
 ##########
 @@ -195,6 +199,14 @@ private void start() throws IOException {
         LOG.error("Unable to finish the execution.", e);
       }
     }
+
+    // If we have got some exception in stateMachine we set the state to
+    // shutdown to stop the stateMachine thread. Along with this we should
+    // also stop the datanode.
+    if (context.getShutdownStateMachine()) {
 
 Review comment:
   If this check is true means, the state is transitioned to shutdown, we call 
stop() and terminate. So, datanode process is terminated. 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 232536)
    Time Spent: 1h 10m  (was: 1h)

> Stop the datanode, when any datanode statemachine state is set to shutdown
> --------------------------------------------------------------------------
>
>                 Key: HDDS-1456
>                 URL: https://issues.apache.org/jira/browse/HDDS-1456
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Datanode
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Recently we have seen an issue, in InitDatanodeState, there is error during 
> create Path for volume. We set the state to shutdown and this has caused 
> DatanodeStateMachine to stop, but datanode is still running. In this case we 
> should stop Datanode, otherwise, user will know about this when running ozone 
> commands or when user observed metrics like healthy nodes.
>  
> cc [~vivekratnavel]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to