[
https://issues.apache.org/jira/browse/HDDS-1473?focusedWorklogId=234942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234942
]
ASF GitHub Bot logged work on HDDS-1473:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/19 22:07
Start Date: 29/Apr/19 22:07
Worklog Time Spent: 10m
Work Description: swagle commented on pull request #781: HDDS-1473.
DataNode ID file should be human readable.
URL: https://github.com/apache/hadoop/pull/781#discussion_r279558043
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/DatanodeIdYaml.java
##########
@@ -0,0 +1,186 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.ozone.container.common.helpers;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.OutputStreamWriter;
+import java.io.Writer;
+import java.util.LinkedHashMap;
+import java.util.Map;
+
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.collections.MapUtils;
+import org.apache.hadoop.hdds.protocol.DatanodeDetails;
+import org.yaml.snakeyaml.DumperOptions;
+import org.yaml.snakeyaml.Yaml;
+
+import com.google.common.base.Preconditions;
+
+/**
+ * Class for creating datanode.id file in yaml format.
+ */
+public class DatanodeIdYaml {
+
+ private DatanodeIdYaml() {
+
+ }
+
+ /**
+ * Creates a yaml file using DatnodeDetails. This method expects the path
+ * validation to be performed by the caller.
+ *
+ * @param datanodeDetails {@link DatanodeDetails}
+ * @param path Path to datnode.id file
+ */
+ public static void createDatanodeIdFile(DatanodeDetails datanodeDetails,
+ File path) throws IOException {
+ Preconditions.checkNotNull(path);
+ DumperOptions options = new DumperOptions();
+ options.setPrettyFlow(true);
+ options.setDefaultFlowStyle(DumperOptions.FlowStyle.FLOW);
+ Yaml yaml = new Yaml(options);
+
+ try (Writer writer = new OutputStreamWriter(
+ new FileOutputStream(path), "UTF-8")) {
+ yaml.dump(getDatanodeDetailsYaml(datanodeDetails), writer);
+ }
+ }
+
+ /**
+ * Read datanode.id from file.
+ */
+ public static DatanodeDetails readDatanodeIdFile(File path)
+ throws IOException {
+ Preconditions.checkNotNull(path);
+ DatanodeDetails datanodeDetails;
+ try (FileInputStream inputFileStream = new FileInputStream(path)) {
+ Yaml yaml = new Yaml();
+ DatanodeDetailsYaml datanodeDetailsYaml;
+ try {
+ datanodeDetailsYaml =
+ yaml.loadAs(inputFileStream, DatanodeDetailsYaml.class);
+ } catch (Exception e) {
+ throw new IOException("Unable to parse yaml file.", e);
+ }
+
+ DatanodeDetails.Builder builder = DatanodeDetails.newBuilder();
+ builder.setUuid(datanodeDetailsYaml.getUuid().toString())
+ .setIpAddress(datanodeDetailsYaml.getIpAddress())
Review comment:
Should I remove it from being serialized?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 234942)
Time Spent: 1.5h (was: 1h 20m)
> DataNode ID file should be human readable
> -----------------------------------------
>
> Key: HDDS-1473
> URL: https://issues.apache.org/jira/browse/HDDS-1473
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode
> Reporter: Arpit Agarwal
> Assignee: Siddharth Wagle
> Priority: Major
> Labels: newbie, pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The DataNode ID file should be human readable to make debugging easier. We
> should use YAML as we have used it elsewhere for meta files.
> Currently it is a binary file whose contents are protobuf encoded. This is a
> tiny file read once on startup, so performance is not a concern.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
