[
https://issues.apache.org/jira/browse/HDDS-1473?focusedWorklogId=234941&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234941
]
ASF GitHub Bot logged work on HDDS-1473:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/19 22:07
Start Date: 29/Apr/19 22:07
Worklog Time Spent: 10m
Work Description: swagle commented on pull request #781: HDDS-1473.
DataNode ID file should be human readable.
URL: https://github.com/apache/hadoop/pull/781#discussion_r279556758
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestMiniOzoneCluster.java
##########
@@ -132,6 +134,13 @@ public void testDatanodeIDPersistent() throws Exception {
File validIdsFile = new File(WRITE_TMP, "valid-values.id");
validIdsFile.delete();
ContainerUtils.writeDatanodeDetailsTo(id1, validIdsFile);
+ // Validate using yaml parser
+ Yaml yaml = new Yaml();
+ try {
+ yaml.load(new FileReader(validIdsFile));
+ } catch (Exception e) {
Review comment:
This is so that unit test fails when an exception is caught with said
message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 234941)
Time Spent: 1h 20m (was: 1h 10m)
> DataNode ID file should be human readable
> -----------------------------------------
>
> Key: HDDS-1473
> URL: https://issues.apache.org/jira/browse/HDDS-1473
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode
> Reporter: Arpit Agarwal
> Assignee: Siddharth Wagle
> Priority: Major
> Labels: newbie, pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The DataNode ID file should be human readable to make debugging easier. We
> should use YAML as we have used it elsewhere for meta files.
> Currently it is a binary file whose contents are protobuf encoded. This is a
> tiny file read once on startup, so performance is not a concern.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
